Fix #1316: use table to define process #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove more text from "Defining a Valid AWP" because the text is already in the Methods section.
rtoy
changed the title
rtoy
changed the title
|
PTAL at this general approach. Might be best to look at the preview (not diff), section 1.33.4.3. This introduces two new bikeshed warnings but I think it makes it much easier to read and understand because it matches how other methods are described. Can't define this method in IDL, so these warnings will just have to live. The alternative is to do this by hand using html. Prefer not to do that so that we remain consistent with what bikeshed does. The section on defining a valid processor is pretty short now. Not exactly sure what to do here. |
|
Actually this looks good! I was wondering about how Bikeshed will handle this IDL mismatch, but I can live with a warning. LGTM. |
hoch
approved these changes
May 16, 2018
State what the types are for the `inputs` and `outputs` parameters to `process()`. Remove the section about defining a valid processor because this no longer adds anything more that isn't already covered by the existing examples..
rtoy
added a commit
to rtoy/web-audio-api
that referenced
this pull request
May 17, 2018
rtoy
added a commit
that referenced
this pull request
May 17, 2018
Regenerate HTML 2018-05-17 after PR #1618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff